From 3d4da1f3c432d99f85f00fa8f644e46f0b8c1676 Mon Sep 17 00:00:00 2001
From: Edward Cheng <edward@cheng.sydney>
Date: Wed, 28 Aug 2024 01:04:43 +1000
Subject: [PATCH] remove ingress for argo-workflows and set argo-server service
 as LB

---
 .../argo-workflows/base/ingress.yaml          | 21 -------------------
 .../argo-workflows/base/kustomization.yaml    |  3 +--
 infrastructures/argo-workflows/base/svc.yaml  |  4 ++++
 3 files changed, 5 insertions(+), 23 deletions(-)
 delete mode 100644 infrastructures/argo-workflows/base/ingress.yaml

diff --git a/infrastructures/argo-workflows/base/ingress.yaml b/infrastructures/argo-workflows/base/ingress.yaml
deleted file mode 100644
index b98f429..0000000
--- a/infrastructures/argo-workflows/base/ingress.yaml
+++ /dev/null
@@ -1,21 +0,0 @@
-apiVersion: networking.k8s.io/v1
-kind: Ingress
-metadata:
-  name: argo-workflows-ingress
-  namespace: argo
-  annotations:
-    nginx.ingress.kubernetes.io/ssl-redirect: "false"
-    nginx.ingress.kubernetes.io/use-regex: "true"
-spec:
-  ingressClassName: nginx
-  rules:
-    - host: "argo-workflows.cluster.edward.sydney"
-      http:
-        paths:
-          - pathType: Prefix
-            path: "/"
-            backend:
-              service:
-                name: argo-server
-                port:
-                  number: 2746
\ No newline at end of file
diff --git a/infrastructures/argo-workflows/base/kustomization.yaml b/infrastructures/argo-workflows/base/kustomization.yaml
index 39c7883..8e8f3e7 100644
--- a/infrastructures/argo-workflows/base/kustomization.yaml
+++ b/infrastructures/argo-workflows/base/kustomization.yaml
@@ -11,5 +11,4 @@ resources:
   - ./secret.yaml
   - ./svc.yaml
   - ./pc.yaml
-  - ./deployment.yaml
-  - ./ingress.yaml
\ No newline at end of file
+  - ./deployment.yaml
\ No newline at end of file
diff --git a/infrastructures/argo-workflows/base/svc.yaml b/infrastructures/argo-workflows/base/svc.yaml
index 4f7de86..2bec75e 100644
--- a/infrastructures/argo-workflows/base/svc.yaml
+++ b/infrastructures/argo-workflows/base/svc.yaml
@@ -2,9 +2,13 @@
 apiVersion: v1
 kind: Service
 metadata:
+  annotations:
+    metallb.universe.tf/address-pool: k3s-cluster-ip-pool
+    metallb.universe.tf/allow-shared-ip: k3s-cluster
   name: argo-server
   namespace: argo
 spec:
+  type: LoadBalancer
   ports:
     - name: web
       port: 2746